Open
Conversation
Dilicom v3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note : this causes a bc-break on
dev-master!Dilicom's v3 API expects several additional parameters => here they are.
I didn't implement any kind of compatibility with v1, as v1 is being de-activated -- and doesn't work anymore, anyway. So there is a huge bc-break on
master(and, as there were no tag previously, this could be bad for end-users... )On our side, we created a
1.0.0tag before merging this, and a2.0.0tag just after merging this. The idea being to be semver-compliant starting from now, instead of having users depend ondev-master.