Fixed proxying pages with encoding other than utf-8#5
Open
asagajda wants to merge 1 commit intoimjacobclark:masterfrom
Open
Fixed proxying pages with encoding other than utf-8#5asagajda wants to merge 1 commit intoimjacobclark:masterfrom
asagajda wants to merge 1 commit intoimjacobclark:masterfrom
Conversation
Owner
|
@asagajda Thanks for the PR, could you fix the failing tests and potentially add some for the new functionality? I'll look to merge this then! Thanks. |
Owner
|
This looks great, are you able to add any tests so I can get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Jacob, thank you for sharing great tool!
Take a look at my PR, that fixes broken encoding when trying to proxy pages with encoding other than utf-8.
You can reproduce problem by querying http://localhost:3000/https://newtimes.ru/rubrics/ as example.