Fixed headers#1
Open
innolabeveris wants to merge 4 commits intoimjacobclark:masterfrom
everis-innolab:master
Open
Fixed headers#1innolabeveris wants to merge 4 commits intoimjacobclark:masterfrom everis-innolab:master
innolabeveris wants to merge 4 commits intoimjacobclark:masterfrom
everis-innolab:master
Conversation
bootstrap.js
Outdated
|
|
||
| module.exports = function(app){ | ||
| function setHeaders(res, origin){ | ||
| if(debug) console.info("setHeaders origin:" , JSON.stringify(origin.headers)); |
Owner
There was a problem hiding this comment.
Could this be switched into a full if statement with braces?
Owner
|
Thanks for the pull request! I've added a few comments to the diff, if you could take a look over them I'd be happy to re-review this, test it out and hopefully get it merged in! Nice work. |
|
I've commited a new patch related to your suggestions here. |
Owner
|
@mrmx @innolabeveris I intent to merge this shortly, sorry for the delay, I have been adding a few unit tests and other refactoring, should land this week! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've corrected the request headers passing to the proxied url plus some gotchas.