Skip to content

Configurable convert options#9

Open
arildm wants to merge 1 commit intoimalhasaranga:masterfrom
arildm:configurable-convert-options
Open

Configurable convert options#9
arildm wants to merge 1 commit intoimalhasaranga:masterfrom
arildm:configurable-convert-options

Conversation

@arildm
Copy link

@arildm arildm commented Oct 12, 2017

Resolves #8

@imalhasaranga
Copy link
Owner

are all the tests are passing ?

@imalhasaranga
Copy link
Owner

I would like if you can make this an optional parameter which user can set if he want, so code should look like this

        $pdfLibConfigurar = new PDFLibConfigurar();
        $pdfLibConfigurar->setNumRenderingThreads(4);
        $pdfLib = new PDFLib($pdfLibConfigurar);

so users who want to configure the library can create a configurar object and pass it to the constructor of the PdfLIb(); and others who do not want any advance configurations they can use the library the same old way

what do you think ?

@arildm
Copy link
Author

arildm commented May 5, 2018

That would perhaps be slightly better, yes. Because then we don't need to add new public methods to PDFLib. I don't recognize that pattern, but it looks almost like the Builder pattern.

To answer your old question: I never managed to get phpunit running, so I couldn't test it.

@imalhasaranga
Copy link
Owner

Sorry could not reply to you... it is just an example if you could implement builder pattern that would be great!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants