Skip to content

Comments

Include ffmpeg suitable for Apple Silicon macos arm64 platform#114

Merged
almarklein merged 8 commits intoimageio:masterfrom
GenevieveBuckley:issue-71
Jan 16, 2025
Merged

Include ffmpeg suitable for Apple Silicon macos arm64 platform#114
almarklein merged 8 commits intoimageio:masterfrom
GenevieveBuckley:issue-71

Conversation

@GenevieveBuckley
Copy link
Contributor

Closes #71

This PR follows the approach suggested in #71 (comment)

  • Update _definitions.py
    • Make sure the apple silicon platform is detected by get_platform().
    • Add new exe file name to FNAME_PER_PLATFORM.
    • Add entry to WHEEL_BUILDS.

Stilll required:

This comment suggests http://www.osxexperts.net/ is a reliable source for the ffmpeg binary. Example ffmpeg download:

wget https://www.osxexperts.net/ffmpeg7arm.zip
unzip ffmpeg7arm.zip
mv ffmpeg ffmpeg-osx-arm64-v7
shasum -a 256 ffmpeg
# Expected SHA256 checksum
# 326895b16940f238d76e902fc71150f10c388c281985756f9850ff800a2f1499

# https://github.com/imageio/imageio-ffmpeg/issues/71#issuecomment-1549677710
# "Although it is not notarized, so I had to run xattr -c ffmpeg to bless it"
xattr -c ffmpeg-osx-arm64-v7

@GenevieveBuckley GenevieveBuckley marked this pull request as draft June 4, 2024 03:02
@GenevieveBuckley
Copy link
Contributor Author

Marking as draft PR, until the ffmpeg binary for macos arm64 is uploaded.

@almarklein
Copy link
Member

I added the ffmpeg MacOS executable for Silicon: imageio/imageio-binaries@66322a9. Added the same version for x86 for good measure. Their names are: ffmpeg-osx-arm64-v7.0 and ffmpeg-osx-x86-v7.0.

@GenevieveBuckley GenevieveBuckley marked this pull request as ready for review June 6, 2024 00:26
@almarklein almarklein merged commit 444874f into imageio:master Jan 16, 2025
10 checks passed
@almarklein
Copy link
Member

I kinda forgot about this one, sorry about that 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ffmpeg not included in wheel for MacOS M1

2 participants