Skip to content

Fix v1.1.0 charset_normalizer packaging regression#24

Merged
imadreamerboy merged 1 commit intoimadreamerboy:mainfrom
mspinolaeie:fix/v1-1-0-pyinstaller-charset-normalizer
Mar 9, 2026
Merged

Fix v1.1.0 charset_normalizer packaging regression#24
imadreamerboy merged 1 commit intoimadreamerboy:mainfrom
mspinolaeie:fix/v1-1-0-pyinstaller-charset-normalizer

Conversation

@mspinolaeie
Copy link
Copy Markdown
Contributor

Summary

  • fix the PyInstaller release packaging regression introduced by the markitdown 0.1.5 bump
  • explicitly include charset_normalizer and its md__mypyc runtime in the frozen app
  • add packaging regression tests by moving the spec collection logic into a testable helper module

Testing

  • pytest -q tests\test_build_config.py tests\core\test_conversion.py tests\ui\test_home_state.py tests\utils\test_update_checker.py tests\utils\test_translations.py tests\core\test_settings.py tests\core\test_file_utils.py
  • pyinstaller --clean --noconfirm --log-level WARN MarkItDown.spec smoke build, then verify dist/MarkItDown/_internal/charset_normalizer contains both md*.pyd and md__mypyc*.pyd

Closes #23

@imadreamerboy
Copy link
Copy Markdown
Owner

Looks good, thank you!

@imadreamerboy imadreamerboy merged commit 7613416 into imadreamerboy:main Mar 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v1.1.0 Windows release fails with missing charset_normalizer mypyc module

2 participants