Update plugin.autoredirector.php #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed: PHP 8 fatal error when merging xPDOIterator; replaced with safe foreach iteration.
There was a problem hiding this comment.
Pull request overview
This pull request fixes a PHP 8 compatibility issue where array_merge() was being used with an xPDOIterator object, which causes a fatal error. The fix replaces the problematic array_merge() calls with safe foreach iteration to manually add iterator items to the array.
Changes:
- Replaced
array_merge()withforeachiteration for xPDOIterator in two locations - Added empty check for
$resourcebefore callinggetChildIds() - Improved code formatting with proper spacing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (!empty($resource) && ($child_ids = $modx->getChildIds($resource->id, 50, array('context' => $resource->context_key)))) { | ||
| $children = $modx->getIterator('modResource', array('id:IN' => $child_ids)); | ||
| foreach ($children as $child) { | ||
| $resources[] = $child; |
There was a problem hiding this comment.
There is trailing whitespace at the end of this line. Remove the space after the semicolon to maintain clean code formatting.
Suggested change
| $resources[] = $child; | |
| $resources[] = $child; |
| if (!empty($resource) && ($child_ids = $modx->getChildIds($resource->id, 50, array('context' => $resource->context_key)))) { | ||
| $children = $modx->getIterator('modResource', array('id:IN' => $child_ids)); | ||
| foreach ($children as $child) { | ||
| $resources[] = $child; |
There was a problem hiding this comment.
There is trailing whitespace at the end of this line. Remove the space after the semicolon to maintain clean code formatting.
Suggested change
| $resources[] = $child; | |
| $resources[] = $child; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: PHP 8 fatal error when merging xPDOIterator; replaced with safe foreach iteration.