Skip to content

Comments

Remove calls to mpi_distribute#889

Merged
majosm merged 1 commit intoillinois-ceesd:mainfrom
majosm:remove-mpi-distribute
May 1, 2023
Merged

Remove calls to mpi_distribute#889
majosm merged 1 commit intoillinois-ceesd:mainfrom
majosm:remove-mpi-distribute

Conversation

@majosm
Copy link
Collaborator

@majosm majosm commented Apr 25, 2023

After revisiting inducer/meshmode#342 and looking at how mpi_distribute is used inside distribute_mesh, I'm not sure it's actually needed anymore. comm.scatter may be good enough.

Questions for the review:

  • Is the scope and purpose of the PR clear?
    • The PR should have a description.
    • The PR should have a guide if needed (e.g., an ordering).
  • Is every top-level method and class documented? Are things that should be documented actually so?
  • Is the interface understandable? (I.e. can someone figure out what stuff does?) Is it well-defined?
  • Does the implementation do what the docstring claims?
  • Is everything that is implemented covered by tests?
  • Do you see any immediate risks or performance disadvantages with the design? Example: what do interface normals attach to?

@majosm majosm force-pushed the remove-mpi-distribute branch 2 times, most recently from 457b51d to ccfb239 Compare April 26, 2023 04:14
@majosm majosm marked this pull request as ready for review April 26, 2023 15:48
@majosm majosm requested a review from MTCam April 26, 2023 15:48
@majosm majosm force-pushed the remove-mpi-distribute branch from ccfb239 to 8f59dd0 Compare April 27, 2023 19:14
doesn't seem to be necessary anymore
@majosm majosm force-pushed the remove-mpi-distribute branch from 8f59dd0 to b05e98f Compare May 1, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants