Open
Conversation
Adding a linting rule which will prevent negative margins. These are a problem in Ilios because they allow a component to exist outside of it's intended layout which makes working with multiple components in a grouping difficult.
I think these made the layout worse, gone now. I also added a number of screenshot tests and a coruse search test as I was checking this.
Specifically allowing this as it's how the arrows fit back together and it's internal to the component.
This subtle alignment tweak doesn't hold up everywhere. Removing it wholesale, we can put it back later if needed.
This won't intrude on other components as it's positioned absolutely, plus this incantation is kind of a standard and works as is I'm not included to mess with it.
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sometimes (like when we use a {{let}} at the top of a template) the
first element we encounter isn't the container we want to screenshot.
In that case we can actually keep looking and probably find a good one
to use.
Contributor
❌ Visual Diff Report — FAILED864 images compared: 26 different · 96 added · 742 identical DetailsDifferences (26)
Added Files (96)
Download the results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a linting rule which will prevent negative margins. These are a problem in Ilios because they allow a component to exist outside of it's intended layout which makes working with multiple components in a grouping difficult.