Skip to content

Extract Mixin for Ilios Overview#9212

Draft
jrjohnson wants to merge 2 commits intoilios:masterfrom
jrjohnson:i6937-ilios-overview
Draft

Extract Mixin for Ilios Overview#9212
jrjohnson wants to merge 2 commits intoilios:masterfrom
jrjohnson:i6937-ilios-overview

Conversation

@jrjohnson
Copy link
Member

Making this a share style instead of a mixin, and removed the course-overview mixin at the same time as it depended on overview. I didn't update the curriculum inventory as that is slated for deprecation.

Refs ilios/ilios#6937
Fixes ilios/ilios#6963

@netlify
Copy link

netlify bot commented Mar 6, 2026

Deploy Preview for ilios-frontend ready!

Name Link
🔨 Latest commit 720fc01
🔍 Latest deploy log https://app.netlify.com/projects/ilios-frontend/deploys/69ab63d5f3c6400008578276
😎 Deploy Preview https://deploy-preview-9212--ilios-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Making this a share style instead of a mixin, and removed the
course-overview mixin at the same time as it depended on overview. I
didn't update the curriculum inventory as that is slated for
deprecation.
@jrjohnson jrjohnson force-pushed the i6937-ilios-overview branch from a073a6d to 720fc01 Compare March 6, 2026 23:31
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

❌ Visual Diff Report — FAILED

768 images compared: 384 different · 384 identical

Details

Differences (384)

File Diff % Notes
desktop-Acceptance _ Course - Cohorts _ manage cohorts _ .png 100.00% ⚠️ Dimension mismatch (1030x1000 → 1058x1000)
desktop-Acceptance _ Course - Competencies _ collapsed competencies renders _ .png 100.00% ⚠️ Dimension mismatch (1122x1000 → 1154x1000)
desktop-Acceptance _ Course - Leadership _ collapsed leadership _ .png 100.00% ⚠️ Dimension mismatch (1341x1000 → 1390x1000)
desktop-Acceptance _ Course - Leadership _ list leadership _ .png 100.00% ⚠️ Dimension mismatch (1248x1000 → 1288x1000)
desktop-Acceptance _ Course - Learning Materials _ list double linked learning materials _ .png 100.00% ⚠️ Dimension mismatch (1249x1000 → 1291x1000)
desktop-Acceptance _ Course - Multiple Objective Parents _ initial view _ .png 100.00% ⚠️ Dimension mismatch (1092x1000 → 1124x1000)
desktop-Acceptance _ Course - Objective List _ list objectives _ .png 100.00% ⚠️ Dimension mismatch (718x1000 → 732x1000)
desktop-Acceptance _ Course - Objective List _ long objective _ .png 100.00% ⚠️ Dimension mismatch (1035x1000 → 1064x1000)
desktop-Acceptance _ Course - Objective Mesh Descriptors _ cancel changes _ default background color.png 100.00% ⚠️ Dimension mismatch (1007x1000 → 1035x1000)
desktop-Acceptance _ Course - Objective Mesh Descriptors _ cancel changes _ managed background color.png 100.00% ⚠️ Dimension mismatch (975x1000 → 1000x1000)
desktop-Acceptance _ Course - Objective Mesh Descriptors _ manage terms _ default background color.png 100.00% ⚠️ Dimension mismatch (1007x1000 → 1035x1000)
desktop-Acceptance _ Course - Objective Mesh Descriptors _ manage terms _ managed background color.png 100.00% ⚠️ Dimension mismatch (975x1000 → 1000x1000)
desktop-Acceptance _ Course - Objective Mesh Descriptors _ save terms _ default background color.png 100.00% ⚠️ Dimension mismatch (1007x1000 → 1035x1000)
desktop-Acceptance _ Course - Objective Mesh Descriptors _ save terms _ managed background color.png 100.00% ⚠️ Dimension mismatch (975x1000 → 1000x1000)
desktop-Acceptance _ Course - Objective Parents _ cancel changes _ default background color.png 100.00% ⚠️ Dimension mismatch (1041x1000 → 1069x1000)
desktop-Acceptance _ Course - Objective Parents _ cancel changes _ managed background color.png 100.00% ⚠️ Dimension mismatch (901x1000 → 923x1000)
desktop-Acceptance _ Course - Objective Parents _ save changes _ objective list.png 100.00% ⚠️ Dimension mismatch (1041x1000 → 1069x1000)
desktop-Acceptance _ Course - Objective Parents _ save changes _ objective manager.png 100.00% ⚠️ Dimension mismatch (901x1000 → 923x1000)
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 1st objective list item collapsed again.png 100.00% ⚠️ Dimension mismatch (685x1000 → 697x1000)
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 1st objective list item collapsed.png 100.00% ⚠️ Dimension mismatch (685x1000 → 697x1000)
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 1st objective list item expanded.png 100.00% ⚠️ Dimension mismatch (550x1000 → 558x1000)
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 2nd objective list item collapsed again.png 100.00% ⚠️ Dimension mismatch (685x1000 → 697x1000)
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 2nd objective list item collapsed.png 100.00% ⚠️ Dimension mismatch (685x1000 → 697x1000)
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 2nd objective list item expanded.png 100.00% ⚠️ Dimension mismatch (441x1000 → 446x1000)
desktop-Acceptance _ Course - Objective Parents - Faded Status Sync _ objective description and parent objectives faded statuses are synced _ 3rd objective list item collapsed again.png 100.00% ⚠️ Dimension mismatch (685x1000 → 697x1000)
… and 359 more

Download the results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

course-overview()

1 participant