New Offering title now in line with other elements, saving space#9200
Open
michaelchadwick wants to merge 2 commits intoilios:masterfrom
Open
New Offering title now in line with other elements, saving space#9200michaelchadwick wants to merge 2 commits intoilios:masterfrom
michaelchadwick wants to merge 2 commits intoilios:masterfrom
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
❌ Visual Diff Report — FAILED768 images compared: 50 different · 718 identical DetailsDifferences (50)
Download the results. |
jrjohnson
requested changes
Mar 4, 2026
Member
jrjohnson
left a comment
jrjohnson
left a comment
There was a problem hiding this comment.
Negative margin breaks layout on mobile. Maybe drop the margin to 0?
New:
Current:
…with other elements
…ing-type selection and hide/show calendar button
michaelchadwick
force-pushed
the
frontend-6956_6957-session-offering-space-saving
branch
from
a2cbeb2 to
1725fe6
Compare
Contributor
Author
|
@jrjohnson Made an exception for mobile, and added some clearance between the two button groups. Phone: Above Phone: |
jrjohnson
requested changes
Mar 6, 2026
| margin-top: 1rem; | ||
|
|
||
| @include m.for-phone-and-up { | ||
| margin-top: -1.65rem; |
Member
There was a problem hiding this comment.
Note from code jam: go to zero margin to avoid moving into space owned by other components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ilios/ilios#6956
Fixed ilios/ilios#6957
Had to use negative margin to get it to sit correctly, but it looks nice.