Mostly replace font-size($step) SASS mixin with equivalent CSS classes#8997
Mostly replace font-size($step) SASS mixin with equivalent CSS classes#8997michaelchadwick wants to merge 18 commits intoilios:masterfrom
font-size($step) SASS mixin with equivalent CSS classes#8997Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
f771fe7 to
0437cb5
Compare
|
The mixin has been extinguished, but the second-to-last commit, uh, commits a grievous error: simply adding the new shared class's attributes to a bunch of deeply-nested places that I couldn't yet figure out how to untangle. |
9a386ed to
941140e
Compare
font-size($step) SASS mixin with equivalent CSS classesfont-size($step) SASS mixin with equivalent CSS classes
941140e to
229f6df
Compare
|
the remaining usage of these mixins. |
stopfstedt
left a comment
There was a problem hiding this comment.
couple of minor shifts, padding related i think, that the differ and Percy caught.
i'm ok with that.
229f6df to
42b17d0
Compare
07fbf18 to
90ae614
Compare
…ke a couple exceptions in shared font-size file, however
…ded class to main component
…ppropriate font-size-x class where it was used
…mixins, as well as some other various places
…ease at best, and inconsistent font-size with the year picker next to it at worst
… TODO fix this so it uses the font-size shared class
…me tricky spots we do not have a solution for yet
90ae614 to
09aa070
Compare
Visual Diff Results🔍 Comparing screenshots... Baseline: /home/runner/work/frontend/frontend/baseline-frontend 📊 Results: ❌ Visual differences detected. 📄 Report generated: /home/runner/work/frontend/frontend/visual-diff-8997/index.html Download the results. |
Refs ilios/ilios#6608
Fixes ilios/ilios#6710
This is a biggie, and will be done in several passes:
I'm trying to keep commits generally within those boundaries so my journey can be properly followed along with.