Draft
Conversation
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
To prevent bugs such as we had with validating the session overview, where an error in a field that isn't currently open or showing errors prevents validation, this now logs those errors to the console. This isn't visible much to users, as it's in the console, but I used the intl service to translate them into nice errors anyway.
We use the `values` key to pass information to the translation, it should always be an object and if it's not set (for instance in a `test` type of validation where it's developer specified) we should account for that and not expect it to be present. This is what we do in the validations message component.
Sometimes we validate a non-ember thing (like ProposedUser) and it doesn't have an owner. In that case we can pass one in.
jrjohnson
force-pushed
the
yup-log-errors
branch
from
43cabbd to
eba2127
Compare
Member
Author
|
I'm keeping this in draft mode, not sure if it's a good idea. It makes tests noisy. Also, is it overly complicated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent bugs such as we had with validating the session overview (#8492), where an error in a field that isn't currently open or showing errors prevents validation, this now logs those errors to the console. This isn't visible much to users, as it's in the console, but I used the intl service to translate them into nice errors anyway.