Added (currently) failing test for correctness#35
Draft
Conversation
Contributor
|
I suggest the following: we use Since the offsets are anyhow fresh computed for any call into marching_cubes/src/marching_cubes.cpp Line 330 in 5bf9472 but besides from that, it should be easy. And these stride related issues should be gone (and the impl is finally in C-order not fortran order) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imo marching cubes should deliver correct results under the assumption of C-ordered arrays with x as fastest varying index.
I added a test that demonstrates that this is currently not the case; sample test output:
here one can see, that z and x coordinates are flipped.
See also #34