feat(iits-admin-dashboard): add servicemonitor #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krankkkk
force-pushed
the
admin-svcmonitor
branch
from
8203bb7 to
4a4fa0b
Compare
krankkkk
requested changes
May 12, 2025
Comment on lines
+26
to
+27
| target: | ||
| - {{ $.Values.ingress.host }} |
Contributor
There was a problem hiding this comment.
this does not work, the target needs to consist of schema + host + path.
You are also not iterating over what the actual endpoints the ingress exposes, but are simply hardcoding a single (wrong) value.
| action: replace | ||
| - sourceLabels: [ target ] | ||
| targetLabel: target | ||
| replacement: {{ $.Values.ingress.host }} |
Contributor
|
We also want the monitoring default enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.