Remove improper use of cfg file by multiple imports#21
Open
Danfoa wants to merge 1 commit intoiit-DLSLab:mainfrom
Open
Remove improper use of cfg file by multiple imports#21Danfoa wants to merge 1 commit intoiit-DLSLab:mainfrom
Danfoa wants to merge 1 commit intoiit-DLSLab:mainfrom
Conversation
This commit removes the multiple imports to the configuration file from different modules within the pipeline. This hinders the hability to customize the system's configuration, since each submodule is reloading a fixed / outdated configuration
Collaborator
|
Hi! This is much needed, i know... I think that many other import are hidden inside the gradient and sampling mpcs, so this need still some rework |
Collaborator
Author
|
I checked and removed all cfg imports on the project and outside of the simulation script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the multiple imports to the configuration file from different modules within the pipeline.
This hinders the hability to customize the system's configuration, since each submodule is reloading a fixed / outdated configuration