ArbitraryTypeReader.NameMapper #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param nameMapper The name mapper from the implicit scope, or the default name mapper if not found | ||
| * @return The name mapper to be used in current implicit scope | ||
| */ | ||
| def get(implicit nameMapper: NameMapper = DefaultNameMapper) = nameMapper |
There was a problem hiding this comment.
hmm, not sure how I feel about the name get here, usually we made such implicit instance summon helper method the apply method.
shanielh
force-pushed
the
feature/name-mapper
branch
from
0985ebe to
77bfd9f
Compare
|
LGTM, @joprice wanna take a look as well? |
| config = c.Expr[Config](Ident(TermName("config"))), | ||
| path = c.Expr[String](Ident(TermName("path")))).splice | ||
| path = c.Expr[String](Ident(TermName("path"))), | ||
| mapper = c.Expr[NameMapper](q"""net.ceedubs.ficus.readers.NameMapper()""")).splice |
There was a problem hiding this comment.
I think you want to add _root_ here to preserve hygiene (since someone could use this inside a package which contains a subpackage named net. See the notes on hygiene here http://docs.scala-lang.org/overviews/quasiquotes/hygiene.
A new way to define name conventions to use in ficus
shanielh
force-pushed
the
feature/name-mapper
branch
from
77bfd9f to
eaa655d
Compare
Author
|
@kailuowang @joprice Fixed all the comments, instead the one in the tests, Where I tried to follow the convention of the rest of the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new way to define name conventions to use in ficus
Continue to #13