Open
Conversation
evgenyigumnov
requested changes
Jul 3, 2024
Collaborator
Author
shitcodebykaushik
left a comment
There was a problem hiding this comment.
The src broadcast file has been updated.
evgenyigumnov
requested changes
Jul 3, 2024
| @@ -1,9 +1,8 @@ | |||
| use std::future::Future; | |||
Member
There was a problem hiding this comment.
igumn@lenovo MINGW64 ~/gabriel2 (shitcodebykaushik-broacdcast)
$ cargo test
warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
Compiling gabriel2 v1.4.3 (C:\Users\igumn\gabriel2\lib)
error[E0252]: the name `DashMap` is defined multiple times
--> lib\src\broadcast.rs:18:5
|
3 | use dashmap::DashMap;
| ---------------- previous import of the type `DashMap` here
...
18 | use dashmap::DashMap;
| ^^^^^^^^^^^^^^^^ `DashMap` reimported here
|
= note: `DashMap` must be defined only once in the type namespace of this module
warning: unused import: `dashmap::DashMap`
--> lib\src\broadcast.rs:18:5
|
18 | use dashmap::DashMap;
| ^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
error[E0308]: mismatched types
--> lib\src\broadcast.rs:107:25
|
107 | for (_id, callback) in subscribers {
| ^^^^^^^^^^^^^^^ ----------- this is an iterator with items of type `dashmap::mapref::multiple::RefMulti<'_, usize, Pin<Box<(dyn EventCallback<E> + 'static)>>>`
| |
| expected `RefMulti<'_, usize, Pin<Box<dyn EventCallback<E>>>>`, found `(_, _)`
|
= note: expected struct `dashmap::mapref::multiple::RefMulti<'_, usize, Pin<Box<(dyn EventCallback<E> + 'static)>>>`
found tuple `(_, _)`
Some errors have detailed explanations: E0252, E0308.
For more information about an error, try `rustc --explain E0252`.
warning: `gabriel2` (lib) generated 1 warning
error: could not compile `gabriel2` (lib) due to 2 previous errors; 1 warning emitted
warning: build failed, waiting for other jobs to finish...
warning: `gabriel2` (lib test) generated 1 warning (1 duplicate)
error: could not compile `gabriel2` (lib test) due to 2 previous errors; 1 warning emitted
| bincode = { version = "2.0.0-rc.3", optional = true } | ||
| async-stream = "0.3.5" | ||
|
|
||
| dashmap = "6.0.1" |
Member
There was a problem hiding this comment.
I think this dependency should be optional.
Only included for "broadcast" feature.
Check for example:
remote = ["tokio/net", "bincode"]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.