Skip to content

Make examples 3.4 compatible #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
broerse wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make examples 3.4 compatible #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,11 @@ It corresponds to _PositionOptions object in HMTL5 Geolocation API_. Learn more
#### Setup geolocation service
In order to use geolocation inside of your _Ember.Route_ you should directly inject it to the one:
```js
export default Ember.Route.extend({
geolocation: Ember.inject.service()
import Route from '@ember/routing/route';
import { inject as service } from '@ember/service';

export default Route.extend({
geolocation: service()
});
```

Expand All @@ -103,12 +106,13 @@ You need to implement a custom action which will call the geolocation service.
In your route:
```js
// app/routes/geolocator.js
import Route from '@ember/routing/route';

export default Ember.Route.extend({
export default Route.extend({

actions: {
getUserLocation: function() {
this.get('geolocation').getLocation().then(function(geoObject) {
this.get('geolocation').getLocation().then((geoObject) => {
var currentLocation = this.get('geolocation').get('currentLocation');
this.controllerFor('geolocator').set('userLocation', currentLocation);
});
Expand All @@ -120,8 +124,9 @@ export default Ember.Route.extend({
In your controller:
```js
// app/controllers/geolocator.js
import Controller from '@ember/controller';

export default Ember.Controller.extend({
export default Controller.extend({
userLocation: null
});
```
Expand All @@ -130,7 +135,7 @@ In your template:
```js
// app/templates/geolocator.hbs

<button type="button" {{action 'getUserLocation'}}>Geolocate me!</button>
<button type="button" {{action "getUserLocation"}}>Geolocate me!</button>
{{#if userLocation}}
{{userLocation}}
{{/if}}
Expand Down