Add unit tests and refactor for testability #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the action to use a JavaScript action structure instead of inline github-script, enabling unit testing of core functionality. Changes: - Delete .gitignore to allow committing dist/ - Extract tag generation logic to src/tag-generator.js - Create src/index.js as main action entry point - Add comprehensive unit tests (23 test cases) - Add package.json with dependencies and test scripts - Use @vercel/ncc to bundle code into dist/index.js - Add CI workflow to run tests on push and PRs - Update action.yml to use node20 runtime All tests pass and the action is now fully testable. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add .gitignore to exclude development artifacts (node_modules, IDE files) while keeping dist/ committed for GitHub Actions. Add npm run clean script using git clean to remove all untracked and ignored files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the action to enable unit testing by extracting the inline GitHub script into separate, testable JavaScript modules.
Key Changes
Refactoring:
actions/github-scriptto JavaScript action (node20runtime)src/tag-generator.jsfor testabilitysrc/index.jsas the main action entry point@vercel/nccto bundle dependencies intodist/index.jsTesting:
src/tag-generator.test.js)CI/CD:
.github/workflows/ci.yml) to run tests on push and PRsOther:
.gitignoreto allow committingdist/(standard practice for GitHub Actions)package.jsonwith dependencies and scriptsTest Coverage
Tests cover:
Breaking Changes
None. The action behavior remains identical; only the internal implementation has changed.
🤖 Generated with Claude Code