-
Notifications
You must be signed in to change notification settings - Fork 0
docs: update gas numbers with verified mainnet tx (85,292 gas) #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…bers - Replace outdated LIQFlashV2/LIQFlashFinal/LIQFlashPaid references with current LIQFlashYul implementation - Add detailed gas breakdown from forge test traces - Update comparison summary with accurate benchmarks (62,846 gas warm vs Balancer's 86,268 min) - Fix gas savings calculations (1.37x cheaper vs USDC, not 5.5x) - Update reproduction instructions with forge test command Co-Authored-By: Player 53627 <github.stagnate430@passmail.com>
Original prompt from Player 53627 |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
- Remove misleading 'x cheaper' claims that compared different measurement bases - Clarify that Foundry gasleft() deltas don't include 21k intrinsic tx gas - Update estimated real tx gasUsed to ~85-90k (comparable to Balancer's 86k min) - Remove WETH comparison (LIQFlashYul is USDC-only) - Remove misleading 'vs avg' comparison (callback logic dominates, not protocol) - Add honest 'Key Observations' section explaining comparable gas costs - List actual advantages of each protocol fairly Co-Authored-By: Player 53627 <github.stagnate430@passmail.com>
- Use README's Tenderly-measured gas numbers (~73k cold, ~41k warm) - Add comparison table matching README format (vs Aave, Balancer, Morpho, Euler) - Add gas savings percentages vs competitors - Add 'Why LIQ Beats Morpho/Euler' section explaining transfer+balanceOf pattern - Update gas breakdown to match README's component breakdown - Add note explaining warm vs cold definitions Co-Authored-By: Player 53627 <github.stagnate430@passmail.com>
- Replaced unverified README numbers with actual Tenderly E2E test results - Flash loan (cold): 83,998 gas (verified via script/test-tenderly.ts) - LIQ vs Balancer USDC min: ~2.6% cheaper (83,998 vs 86,268) - Added methodology section explaining measurement basis (receipt gasUsed) - Removed unverified percentage claims (40-50% cheaper) - Added all operation gas costs from Tenderly test Note: The README claims ~73k cold / ~41k warm, but actual Tenderly measurement shows 83,998 gas for cold flash loan. README may need updating. Co-Authored-By: Player 53627 <github.stagnate430@passmail.com>
- Updated README.md gas comparison table with verified numbers - Updated BALANCER_COMPARISON.md with real mainnet tx data - LIQ: 85,292 gas (verified via etherscan.io/tx/0x35274dd1...) - Balancer USDC min: 86,268 gas (from on-chain data) - Removed unverified claims (~41k warm, ~73k cold) - Added link to real mainnet flash loan transaction Co-Authored-By: Player 53627 <github.stagnate430@passmail.com>
docs: update gas numbers with verified mainnet tx (85,292 gas)
Summary
Updates both README.md and BALANCER_COMPARISON.md with verified gas numbers from a real mainnet transaction, replacing outdated/unverified claims.
Key changes:
Updates Since Last Revision
Found and verified a real mainnet flash loan transaction:
The previous README claims (~73k cold, ~41k warm) could not be reproduced and appear to have used a different measurement methodology. This PR replaces them with verified receipt-level
gasUsedfrom actual transactions.Review & Testing Checklist for Human
Test Plan
Notes
The document went through several iterations:
The previous README numbers (~41k warm) likely measured Tenderly trace "call-frame gas" rather than receipt
gasUsed, which explains the discrepancy.Link to Devin run: https://app.devin.ai/sessions/55585942721f4bcaa48cdfa0c67d9110
Requested by: Player 53627 (github.stagnate430@passmail.com) / @igor53627