-
Notifications
You must be signed in to change notification settings - Fork 0
docs: audit triage - update SECURITY.md and add audit report #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update audit status to reflect AuditAgent scan (Jan 4, 2026) - Remove email contact, add GitHub Issues as reporting method - Add link to GitHub private vulnerability reporting - Document known risk of excess USDC extraction vulnerability - Add audits/ directory with full audit report PDF Co-Authored-By: Player 53627 <github.stagnate430@passmail.com>
…sions Co-Authored-By: Player 53627 <github.stagnate430@passmail.com>
Original prompt from Player 53627 |
|
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
- Add expectedAmount tracking to prevent amount manipulation - Validate initiator is this contract - Validate token is USDC - Validate callback amount matches requested amount Fixes #19 Co-Authored-By: Player 53627 <github.stagnate430@passmail.com>
Co-Authored-By: Player 53627 <github.stagnate430@passmail.com>
…, TestBorrower as fixed Co-Authored-By: Player 53627 <github.stagnate430@passmail.com>
Co-Authored-By: Player 53627 <github.stagnate430@passmail.com>
- New TestBorrower: 0x7e13a21ce933a7122a8d1bdf0aeced4ba48ecad6 - Old TestBorrower (0x53cdd...) had arbitrary lender injection vulnerability - Security fix from PR #22 now deployed on mainnet - Deploy tx: 0x6fbf09875769de685b2118a130ff0b2c1986df29174bd8c2cb7e28062f420350 Co-Authored-By: Player 53627 <github.stagnate430@passmail.com>
* docs: update TestBorrower address after security fix redeployment - New TestBorrower: 0x7e13a21ce933a7122a8d1bdf0aeced4ba48ecad6 - Old TestBorrower (0x53cdd...) had arbitrary lender injection vulnerability - Security fix from PR #22 now deployed on mainnet - Deploy tx: 0x6fbf09875769de685b2118a130ff0b2c1986df29174bd8c2cb7e28062f420350 Co-Authored-By: Player 53627 <github.stagnate430@passmail.com> * docs: update audit_responses.md with deployed TestBorrower address - Updated Finding #1 status to FIXED AND DEPLOYED - Added new TestBorrower mainnet address (0x7e13a21ce933a7122a8d1bdf0aeced4ba48ecad6) - Updated Finding #7 status to FIXED Co-Authored-By: Player 53627 <github.stagnate430@passmail.com> --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Player 53627 <github.stagnate430@passmail.com>
docs: audit triage - update SECURITY.md and add audit report
Summary
Processes the AuditAgent security audit report (Scan ID: 26, January 4, 2026) and updates documentation accordingly. This PR:
audits/directoryaudit_responses.mdGitHub issues created for audit findings - all resolved:
#18: Excess USDC extraction (Medium)- Closed as design decision#20: Missing ERC20 return value checks (Info)- Closed as future version improvement#21: Missing events (Best Practices)- Closed as gas optimization design decisionUpdates since last revision
Review & Testing Checklist for Human
onFlashLoan(): initiator, token, and amount validation. Ensure these prevent the arbitrary lender injection attack described in Issue [Security][High][TestBorrower] Arbitrary lender injection allows draining USDC #19Test Plan
forge testto ensure no regressions (note: fork tests may fail without RPC)Notes
Link to Devin run: https://app.devin.ai/sessions/861106c4151b439ebcb344694d9b611a
Requested by: Player 53627 (github.stagnate430@passmail.com) / @igor53627