Skip to content

Conversation

@PacificViking
Copy link
Contributor

Support a list of urgent windows and corresponding workspaces. Cancels the urgent flag when the urgent window becomes active.

Comment on lines 148 to 157
def urgent_windows(self) -> list[str]:
"""
- read-only

A list of urgent windows.
"""
return list(self._urgent_windows)

@IgnisProperty
def urgent_workspaces(self) -> list[str]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should return a list of HyprlandWindow and HyprlandWorkspace accordingly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be done in my latest commits.

return list(self._urgent_windows)

@IgnisProperty
def urgent_workspaces(self) -> list[str]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, maybe HyprlandWindow and HyprlandWorkspace should simply have is_urgent property? Instead of making separate lists

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that, how would you bind to urgent though? Do you just bind to the windows property at that point?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HyprlandWindow (and HyprlandWorkspace) are GObjects too, so you can bind to them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wouldn't support binding to both properties under HyprlandWindow and the hyprland service though. I might be over-complicating it but how would I do what I'm doing in hyprland_workspaces() in the example bar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants