Skip to content

Conversation

@iprafols
Copy link
Collaborator

This PR implements a new framework to compute the delta field. This is encapsulated in a new ExpectedFlux module and should not affect the current standard runs

Wanted features that are still missing and will be added in future PRs

  • Full tests on the new framework
  • Automatic detection of z edges

The file was using previous schemes and all the tests there had bugs. We need to add the new test file at some point
@iprafols
Copy link
Collaborator Author

something weird is going on with the pylint checks

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a new framework for computing delta fields through an ExpectedFlux module, specifically adding 2D mean continuum functionality that can compute the mean continuum as a function of both wavelength and redshift.

  • Adds new MeanContinuumInterpExpectedFlux class with support for both 1D and 2D interpolation
  • Modifies the continuum computation utilities to handle 2D interpolators
  • Updates configuration to accommodate new framework parameters

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 11 comments.

File Description
pylintrc Extends line length limit and adds matrix variable names to accepted variables
py/picca/delta_extraction/expected_fluxes/utils.py Updates continuum computation to support 2D interpolators and improves error handling
py/picca/delta_extraction/expected_fluxes/mean_continuum_interp_expected_flux.py Implements new framework with 2D mean continuum computation capabilities
.github/workflows/pylint.yml Pins pylint version for consistent CI behavior

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@corentinravoux
Copy link
Contributor

Hi @iprafols thanks for the PR, did you include the changes done by Julien ?

@corentinravoux
Copy link
Contributor

Did you find the issue with pylint ?

@iprafols
Copy link
Collaborator Author

Not yet, I can't seem to even reproduce the issue locally

@iprafols iprafols requested a review from Copilot September 23, 2025 11:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 4 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@iprafols
Copy link
Collaborator Author

@corentinravoux can we merge this now?

@corentinravoux
Copy link
Contributor

Hi @iprafols sorry I was not very available this week.
Since the code added is modular and not impacting the main analysis, and you resolved all copilot raised issues, I am in favor of merging !

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those changes are fixes inside the main analysis ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same code is used in the main analysis, yes. 1. There are three sets of changes:

  1. the one in lines 60-66 (new code) is a basic if to manage the new type for the mean_cont and does not have an impact on the main analyisis
  2. the one in lines 94-109 gets rid of a nasty "errors not positive defined" warning we kept having in iminuit. They don't seem to change the main analysis though
  3. the one in lines 119-120 is an extra test that the continuum is fine, and it might impact a few forests. Now intead of having them full of NaNs, they are simply ignored.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, none of the changes seem to impact the main analysis

Copy link
Contributor

@corentinravoux corentinravoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added two small questions but I am in favor for merging

@corentinravoux corentinravoux changed the title 2d mean continuum [bump minor] 2d mean continuum Sep 25, 2025
@corentinravoux
Copy link
Contributor

Thanks for the changes, I agree that we can merge !

@iprafols iprafols added this pull request to the merge queue Sep 26, 2025
Merged via the queue into master with commit db25d51 Sep 26, 2025
12 checks passed
@iprafols iprafols deleted the 2d_mean_continuum branch September 26, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants