Skip to content

Conversation

@tagliala
Copy link
Member

@tagliala tagliala commented Sep 8, 2025

Fix new Style/RedundantRegexpCharacterClass offense

@tagliala tagliala requested a review from Copilot September 8, 2025 12:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates project dependencies to newer versions and fixes a RuboCop offense related to redundant regular expression character classes.

  • Updates RuboCop and related gems to newer versions with flexible version constraints
  • Fixes Style/RedundantRegexpCharacterClass offense by simplifying regex pattern
  • Changes from exact version pinning to pessimistic version constraints for better dependency management

Reviewed Changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

File Description
lib/heathen/errors.rb Simplifies regex pattern to fix RuboCop offense
gemfiles/rubocop.gemfile Updates RuboCop gems to newer versions with flexible constraints

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

def initialize(method = nil)
calling_method = caller(3..3).first
method = calling_method.gsub(/.*[`](.*)'$/, '\\1')
method = calling_method.gsub(/.*`(.*)'$/, '\\1')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot can you guarantee that [`] and ` are the same in this context?

@tagliala tagliala force-pushed the chore/update-dependencies branch from 66ed05a to e68b50c Compare September 8, 2025 12:27
Fix new `Style/RedundantRegexpCharacterClass` offense

Additionally, update Tika to 3.2.2 and change download URL
@tagliala tagliala force-pushed the chore/update-dependencies branch from e68b50c to 245eaaa Compare September 8, 2025 12:27
@tagliala tagliala merged commit 15cba7f into master Sep 8, 2025
3 checks passed
@tagliala tagliala deleted the chore/update-dependencies branch September 8, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants