implement 2d prefix sums [SATs] for faster algorithmic implementation of epsilon#10
Open
jlotthammer wants to merge 1 commit intomainfrom
Open
implement 2d prefix sums [SATs] for faster algorithmic implementation of epsilon#10jlotthammer wants to merge 1 commit intomainfrom
jlotthammer wants to merge 1 commit intomainfrom
Conversation
… of matrix scan windows, misc ruff formats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to reduce the time complexity of the windowing computation used in the epsilon calculation dramatically by leveraging a summed-area table datastructure to make the window computations constant time after an initial O(m*n) preprocessing stop. For large window sizes - e.g., our default w=31, this results in a ~60-70x speedup.
Todos
Notable points that this PR has either accomplished or will accomplish.
becnhmarking/directory and they are consistent. I think based on all these lines of evidence that it is correct, but I'll have more confidence when things are cleaned up in this codebase and tests are written.