Skip to content

fix: Skipping#76

Open
shamilbi wants to merge 5 commits intoido50:mainfrom
shamilbi:extras
Open

fix: Skipping#76
shamilbi wants to merge 5 commits intoido50:mainfrom
shamilbi:extras

Conversation

@shamilbi
Copy link
Collaborator

this ini:

[requirements]
pyjwt = [crypto]==2.10.1

results in:

[pyjwt[crypto]==2.10.1]: cryptography>=3.4.0; extra == "crypto"
        Skipping, not relevant for any environment

so the code needs to have extras from pyjwt

Copy link
Contributor

@grische grische left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that is correct. If pyjwt does not match your environment, it should NOT pull in cryptography. This will cause a lot of unecessary cruft in your mirror for all potential extras that are never used as the package itself is not compatible.

I'd appreciate if you also do not keep all those AI-generated comments in their. They don't help anyone.

@shamilbi
Copy link
Collaborator Author

shamilbi commented Feb 6, 2026

I don't think that is correct. If pyjwt does not match your environment, it should NOT pull in cryptography. This will cause a lot of unecessary cruft in your mirror for all potential extras that are never used as the package itself is not compatible.

But if pyjwt DOES match the environment, it won't pull in cryptography because the code dont't see extras from pyjwt

I'd appreciate if you also do not keep all those AI-generated comments in their. They don't help anyone.

I thought comments would help to understand diffs. They are not AI-generated :)

@grische
Copy link
Contributor

grische commented Feb 6, 2026

I don't think I understand the use case. Can you write a test that currently fails and is fixed by your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants