Conversation
not supported under MSVC
Cmake files comprise two files, one for the lib placed in src, the other at the root for the test program
Author
|
I have done a draft for CMake. Please note that I am not mastering CMake, so it may be certainly improved. I think it would be nice to be tested on Linux to see if Makefile is generated properly. I have tried to isolate some options proper to VS. |
Author
|
Working on provided examples. |
newling
reviewed
Nov 11, 2019
Collaborator
newling
left a comment
newling
left a comment
There was a problem hiding this comment.
Thank you for this contribution, and sorry for the slow response.
Can you please separate into 2 PRs:
(1) CMake support (files CMakeLists.txt, src/CMakeLists.txt, src/arrutilv2l0.h, src/initialise2.h)
(2) headers and the use of &&.
I will definitely accept (2) immediately, but will need to consider (1) in more detail.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor modifications in the code to be compliant with VS2017. Compilation runs well but not currently tested on samples.
Also, I am working on CMake files to generate the project files.