Add warp_marker support to clips#178
Open
PhotonicVelocity wants to merge 3 commits intoideoforms:masterfrom
Open
Add warp_marker support to clips#178PhotonicVelocity wants to merge 3 commits intoideoforms:masterfrom
PhotonicVelocity wants to merge 3 commits intoideoforms:masterfrom
Conversation
c4527a7 to
b3d09ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds OSC support for clip warp markers. It exposes:
/live/clip/get/warp_markersreturning beat_time/sample_time pairs/live/clip/add_warp_marker(beat_time, sample_time), with optional beat‑only support./live/clip/move_warp_marker(beat_time, beat_time_distance) moves a warp marker at a given beat_time the given distance in beats/live/clip/remove_warp_markerremoves a warp marker at the given beat_timeIt also includes tests that exercise add/move/remove behavior and the beat‑only path.
I also cleaned up the inconsistent spacing of the clips API table as it was annoying me....
Usage
Checklist