Add new read-only clip properties for available_warp_modes, sample_rate, has_envelopes, and clip type booleans#177
Open
PhotonicVelocity wants to merge 1 commit intoideoforms:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A few read-only properties were missing and easy enough to add.
Added clip properties for
available_warp_modes,has_envelopes,is_arrangement_clip,is_session_clip,is_take_lane_clip,sample_rate.New handler added for
available_warp_modessince it returns enum-like objects. Handler converts to list of ints where:0 = Beats Mode,1 = Tones Mode,2 = Texture Mode,3 = Re-Pitch Mode,4 = Complex Mode,5 = REX Mode,6 = Complex Pro Mode.Checklist
For any new or modified API endpoints, I have added unit tests covering the new functionalityI have verified that all unit tests pass (see CONTRIBUTING.md for guidance)