[feature] Chain and Chain Device Implementation#170
[feature] Chain and Chain Device Implementation#170suavesav wants to merge 2 commits intoideoforms:masterfrom
Conversation
|
|
|
|
||
| return rack_callback | ||
|
|
||
| def create_chain_callback(func, *args): |
There was a problem hiding this comment.
I have chain callbacks (/live/chain/) which refer to the properties of the chain itself and chain device callbacks (/live/chain/device/`) which refer to properties of devices within the chain.
Chain devices are different than top level devices because I think we want to access them inside the chain. This allows us to ask for and modify devices inside a chain.
is it okay that they are all in the same file? or would you like the chain device methods to be separated from the chain methods?
| def chain_get_device_types(chain, params: Tuple[Any] = ()): | ||
| return tuple(device.type for device in chain.devices) | ||
|
|
||
| self.osc_server.add_handler("/live/device/get/num_chains", create_rack_callback(rack_device_get_num_chains)) |
There was a problem hiding this comment.
put this /live/device/get/num_chains endpoint in here since it is related to chains, but every other endpoint in here is /live/chain/....
Should I move this to live with the other device endpoints?
There was a problem hiding this comment.
Chains are part of devices so it almost feels like you want to do /live/device/chain/... as your namespace to better represent the hierarchy.
| for chain_device_index, chain_device in enumerate(chain.devices): | ||
| chain_device_data = serialize_device(chain_device) | ||
| chain_device_data["index"] = chain_device_index | ||
| chain_data["devices"].append(chain_device_data) |
There was a problem hiding this comment.
User can have a lot of racks+devices+parameters, which would make the endpoint slower and the output file larger.
should we have a parameter that the user can conditionally set if they don't want rack info in song structure?
| chain_methods = [ | ||
| ] | ||
| chain_properties_r = [ | ||
| "has_audio_input", | ||
| "has_audio_output", | ||
| "has_midi_input", | ||
| "has_midi_output", | ||
| "is_auto_colored", | ||
| "muted_via_solo", | ||
| "color_index" | ||
| ] | ||
| chain_properties_rw = [ | ||
| "name", | ||
| "color", | ||
| "mute", | ||
| "solo" | ||
| ] |
There was a problem hiding this comment.
NIT: this could all be in constants because it doesn't change from invocation to invocation. Negligible performance impact. Minor memory impact on startup if you have a lot of device chains.
3 participants
Description
Please include a summary of the change, and the motivation. If it closes one or more open issues, please tag them as described here.
Checklist
This project is run by a single unpaid maintainer, and long PRs containing a lot of AI-generated content are complex and time-consuming to review. With this in mind, please proof-read all content carefully before submitting, and ensure that surplus files (additional documentation, test procedures, etc) are not checked in before submitting the PR.