Fix leaked global and preserve original error stack in `witness_calculator.js` #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

viktorking7 wants to merge 1 commit into iden3:master from viktorking7:master

viktorking7 commented Sep 23, 2025

Description

Replaced an implicit global (a) with a scoped const to prevent leaks and side effects.
Rethrow original error (throw err) to preserve stack traces during WASM compilation failures.

Why

Avoids hard-to-debug behavior from globals in non-strict JS.
Keeps accurate stack information for troubleshooting.

Scope

File: code_producers/src/wasm_elements/common/witness_calculator.js
No functional changes to public API; behavior is safer and more debuggable.


          Update witness_calculator.js

fdc2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet