fix: resolve assertion error in C++ witness generation for scalar signals in loops #379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #374
Problem:
Assertion
!(ctx->componentMemory[mySubcomponents[cmp_index_ref]].inputCounter)fails when scalar inputs are assigned before array signals in loops.Root Cause:
Input signal analysis incorrectly marks signals as "Last" instead of "Unknown" when scalar signals are assigned before array signals in loops.
Solution:
Modified
visit_address_typefunction to be more conservative in loop contexts:if found_unknown_addresstoif found_unknown_address || inside_loopvisit_loopandvisit_create_cmpfunctions