Open
Conversation
TreyE
force-pushed
the
setting_type_specifiers
branch
2 times, most recently
from
94a0b33 to
35c4422
Compare
TreyE
force-pushed
the
setting_type_specifiers
branch
from
35c4422 to
8297f7c
Compare
Several things here: - We now use dry to automatically validate and convert our option settings. We can use dry to both perform input coercion and crawl the tree for us - we don't need our own code to do that. - Key names can be specified as strings, but will be auto-cast to symbols for us. - Don't silently swallow failures loading option files.
TreyE
force-pushed
the
setting_type_specifiers
branch
from
8297f7c to
2cb18c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several things here:
settings. We can use dry to both perform input coercion and crawl the
tree for us - we don't need our own code to do that.
symbols for us. If we want to ENSURE they must be symbols in the source
yaml, we can easily put it back.