Skip to content

use eligibility year to create previous THHG and remove date check#6117

Open
vkghub wants to merge 8 commits intotrunkfrom
CU_868hg3pd6_v3
Open

use eligibility year to create previous THHG and remove date check#6117
vkghub wants to merge 8 commits intotrunkfrom
CU_868hg3pd6_v3

Conversation

@vkghub
Copy link
Copy Markdown
Contributor

@vkghub vkghub commented Mar 24, 2026

PR Checklist

Please check if your PR fulfills the following requirements:

  • The title follows our guidelines
  • Tests for the changes have been added (for bug fixes/features), and they use let helpers and before blocks.
  • For all UI changes, there is Cucumber coverage.
  • Any endpoint touched in the PR has an appropriate Pundit policy. For open endpoints, the reasoning is documented in the PR and code.
  • Any endpoint modified in the PR only responds to the expected MIME types.
  • For all scripts or rake tasks, how to run them is documented in both the PR and the code.
  • There are no inline styles added.
  • There is no inline JavaScript added.
  • There is no hard-coded text added/updated in helpers/views/JavaScript. New/updated translation strings do not include markup/styles unless there is supporting documentation.
  • Code does not use .html_safe.
  • All images added/updated have alt text.
  • Does not bypass RuboCop rules in any way.

PR Type

What kind of change does this PR introduce?:

  • Bugfix
  • Feature (requires Feature flag)
  • Data fix, Migration, or Report (inert code, no impact until run)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • CI related changes
  • Dependency updates (e.g., add a new gem or update to a version)
  • Release (Prepares code for a release, e.g., version bumps, changelog updates, tagging, deployment scripts)

What is the ticket # detailing the issue?

Ticket: https://app.clickup.com/t/868hg3pd6 & https://app.clickup.com/t/868hg3pgz

A brief description of the changes:

New behavior: fix previous year eligibility bug

Feature Flag

For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.

Variable name:

  • DC
  • ME

Additional Context

Include any additional context that may be relevant to the peer review process.

@vkghub vkghub added the enhancement New feature or request label Mar 24, 2026
@vkghub vkghub self-assigned this Mar 24, 2026
@vkghub vkghub marked this pull request as ready for review March 24, 2026 19:31
@vkghub vkghub changed the title use eligibility year to create previous THHG and remove date check fo… use eligibility year to create previous THHG and remove date check Mar 24, 2026
Copy link
Copy Markdown
Contributor

@satish2025-crew satish2025-crew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Copy Markdown
Contributor

@saipraveen18 saipraveen18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants