ridp_rba : add subscribers and publisher in EA#6090
Open
jayreddy519 wants to merge 5 commits intotrunkfrom
Open
ridp_rba : add subscribers and publisher in EA#6090jayreddy519 wants to merge 5 commits intotrunkfrom
jayreddy519 wants to merge 5 commits intotrunkfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds AMQP publisher and subscriber for RIDP RBA (Risk-Based Authentication) to enable communication with the FDSH Gateway for identity proofing.
Changes:
- New
RidpRbaPublisherthat registersdetermination_requestedandget_record_requestedevents on theenroll.ridp_rbaexchange. - New
RidpRbaDeterminationSubscriberthat consumes from thefdsh.ridp_rbaexchange and delegates to aProcessDeterminationResponseoperation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/event_source/publishers/fdsh/ridp_rba_publisher.rb | New publisher for RIDP RBA events |
| app/event_source/subscribers/fdsh_gateway/ridp_rba_determination_subscriber.rb | New subscriber consuming RIDP RBA determination responses |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/event_source/subscribers/fdsh_gateway/ridp_rba_determination_subscriber.rb
Outdated
Show resolved
Hide resolved
Contributor
|
Add event files to publisher and subscriber. |
Contributor
Author
|
Added event files to publisher && subscriber. |
ymhari
requested changes
Mar 24, 2026
| handle_failure_response(job_id) | ||
| logger.info 'FdshGateway::RidpRbaDeterminationSubscriber: on_determined acked and processed failure from fdsh_gateway' | ||
| else | ||
| result = Operations::Fdsh::RidpRba::ProcessDeterminationResponse.new.call( |
Contributor
There was a problem hiding this comment.
Comment this as the operation has not been built yet.
jayreddy519
force-pushed
the
CU_868htgrzy
branch
from
f13bcca to
557dfca
Compare
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
app/event_source/subscribers/fdsh_gateway/ridp_rba_determination_subscriber.rb
Fixed
Show fixed
Hide fixed
…ariable' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> Signed-off-by: Jay Reddy <jayanth.rordev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
lethelpers andbeforeblocks..html_safe.PR Type
What kind of change does this PR introduce?:
What is the ticket # detailing the issue?
Ticket: https://app.clickup.com/t/868htgrzy
A brief description of the changes:
Current behavior:
No AMQP publisher exists for RIDP RBA in Enroll.
No subscriber exists in Enroll to receive RIDP RBA determination responses from FDSH Gateway.
New behavior:
Publishers::Fdsh::RidpRbaPublisher publishes determination_requested and get_record_requested events to enroll.ridp_rba exchange.
Subscribers::FdshGateway::RidpRbaDeterminationSubscriber consumes from fdsh.ridp_rba exchange and delegates to ProcessDeterminationResponse operation.
Feature Flag
For all new feature development, a feature flag is required to control the exposure of the feature to our end users. A feature flag needs a corresponding environment variable to initialize the state of the flag. Please share the name of the environment variable below that would enable/disable the feature and indicate which client(s) it applies to.
Variable name:
Additional Context
Include any additional context that may be relevant to the peer review process.