Fix audio crash with AirPods Max and multi-channel devices#3
Merged
idanyekutiel merged 1 commit intomainfrom Mar 23, 2026
Merged
Fix audio crash with AirPods Max and multi-channel devices#3idanyekutiel merged 1 commit intomainfrom
idanyekutiel merged 1 commit intomainfrom
Conversation
Three fixes for crashes triggered by Bluetooth/external audio devices: 1. Always request mono format for the tap — multi-channel devices (AirPods Max, Studio Display) deliver multi-channel buffers that crash when written to a mono output file. 2. Full engine teardown + rebuild on config change instead of trying to patch up a partially-reset engine. The old approach caused an ObjC NSException in installTapOnBus that Swift cannot catch. 3. Make removeTap() unconditional — the tapInstalled flag could get out of sync after config changes, leaving a stale tap that blocks reinstallation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSExceptionininstallTapOnBus("required condition is false: !_tapNode"), resulting inSIGABRT.removeTap()no longer guards on thetapInstalledflag, which could get out of sync after config changes.removeTap(onBus:)is a safe no-op when no tap exists.Test plan