Fix AudioBufferList heap overflow with Studio Display microphone#2
Merged
idanyekutiel merged 1 commit intomainfrom Mar 13, 2026
Merged
Conversation
…e Studio Display AudioBufferList is a variable-length struct (mBuffers array is variable-size). The old code allocated fixed-size storage (MemoryLayout<AudioBufferList>.size) which only fits one AudioBuffer entry. Devices with multiple stream buffers (e.g. Studio Display's 3-mic array) overflow this allocation. Now allocates based on actual streamSize reported by CoreAudio, matching the pattern used by openal-soft and other audio libraries. Fixes crash on app launch/device enumeration when Studio Display is connected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes crash on app launch/startup when Apple Studio Display is connected. The bug was in device enumeration code that didn't properly handle multi-buffer audio devices.
Root Cause
AudioBufferList is a variable-length C struct where the mBuffers array can contain multiple AudioBuffer entries. The old code allocated fixed-size storage (
MemoryLayout<AudioBufferList>.size) which only fits one entry. Devices with multiple stream buffers (like the Studio Display's 3-microphone array) overflow this allocation, causing heap corruption and crash.Fix
Allocate based on actual
streamSizereported by CoreAudio instead of using fixed-size storage. This matches the pattern used by openal-soft and other audio libraries handling variable-length CoreAudio structures.Testing