Open
Conversation
c38581a to
90eb30c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to serialization that should allow for better compatibility with other json serialization libraries
Special floating point numbers
Currently
"Infinity"and "NaN"are considered valid values forDoubleandFloat` properties. Disabling this behaviour should be safe since:JSON.stringifyby default mapsNaNand infinite values to nullNaNor infinite valuesThere seem to be no configuration that allows disabling this behaviour, the only solution is to create custom serializers for these types and registering them on the object mapper.
The serializers introduced with this module will:
NaNor infinite valuesFloatorDoublevalues are encoded as strings in the input jsonFloatorDoubleare too big and would be decoded as infinityNotes:
InfinityorNaN(unquoted) were already not accepted (by default)Scalar coercion
Jackson by default has a configuration
ALLOW_COERCION_OF_SCALARSwhich allows parsing without errors also inputs like{ "double": "2.0" }or{ "double": true }.This configuration should be disabled in a future update but:
TODO Lite / Kmehr
SharedWebConfig.getJackson2JsonEncodermethod now takes the object mapper in input. Make sure to use that instead of creating a new one