Skip to content

Service filtering and retrieval improvements#145

Draft
trema96 wants to merge 3 commits intomainfrom
fix/service-filtering
Draft

Service filtering and retrieval improvements#145
trema96 wants to merge 3 commits intomainfrom
fix/service-filtering

Conversation

@trema96
Copy link
Contributor

@trema96 trema96 commented Feb 11, 2025

Changes to getServices

  • More efficient implementation of get services that uses map/reduce views only instead of requiring additional filtering on kraken
  • Use contact modified date instead of service modified date to decide latest version.
  • Should generally match, but in case of changes to contact level metadata, the service could remain unchanged.

Changes to service filtering

Previous implementation of service filtering would return all service ids that matched the request at some point. The new implementation will check that the latest version of the service still matches the request before returning it.

Base automatically changed from api-analysis-fixes to main July 9, 2025 08:53
@trema96
Copy link
Contributor Author

trema96 commented Jan 12, 2026

Partially included as part of #222, where the newly introduced filters use a reduced view for getting the contact with the latest version of a service:

  • The actual "getServices" method was not yet updated
  • Existing filters were unchanged

To complete this PR we need to:

  • Add a new version of all existing filters that rely on the reduced view
  • Ensure that either all DBs have indexed the view needed for this version of getServices, or have a fallback in case the view does not exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant