Make version optional in medication scheme generation#92
Open
Make version optional in medication scheme generation#92
Conversation
LotuxPunk
approved these changes
Nov 28, 2024
TestaDiRapa
requested changes
Nov 28, 2024
| @RequestParam language: String, | ||
| @RequestParam recipientSafe: String, | ||
| @RequestParam(defaultValue = "0") version: Int, | ||
| @RequestParam(required = false, defaultValue = "0") version: Int, |
Collaborator
There was a problem hiding this comment.
I read mattermost, if defaultValue is not recognized put it required false and not nullable may not work either.
Suggested change
| @RequestParam(required = false, defaultValue = "0") version: Int, | |
| @RequestParam(required = false, defaultValue = "0") version: Int = 0, |
Contributor
Author
There was a problem hiding this comment.
From what I remember "= 0" does not work. In every other instance we use @RequestParam(required = false, defaultValue = "0"). But you are right... Tests will be needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.