Conversation
LotuxPunk
approved these changes
Oct 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to kerberus to ensure the
resolveChallengemethod yields at least between different progress reports.JS
Due to recent changes to subtle crypto on chrome (sha and other methods now return fulfilled promises)
resolveChallengewas no longer letting the DOM update between calls.Kotlin yield doesn't seem to let js process the event queue reliably, to ensure kerberus behaves decently on Chrome we use a setTimeout(-, 0) for yielding from resolveChallenge in js.
A better solution would be to create a kerberus version in pure js which uses web workers (it is not possible to do it with kotiln due to coroutines not being able to run in a web worker context amongst others).