Add GHC 9.10.2 & update Prometheus dependency #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capture changes due to new version of haskell-ci.
prometheus 2.3.0 changes the behaviour of the `observeAndSample` function: - bitnomial/prometheus#51 This does not seem to require any changes in Ridley. Change log: - https://github.com/bitnomial/prometheus/blob/master/CHANGELOG.md#230
PiDelport
changed the title
adinapoli
reviewed
Aug 27, 2025
| shelly >= 1.8.2, | ||
| safe-exceptions < 1.8, | ||
| transformers, | ||
| prometheus > 0.5.0 && < 2.3.0, |
Contributor
There was a problem hiding this comment.
Thanks @PiDelport ! I remember adding that constraint because there were a few breaking changes in prometheus-2.3.0, but I don't remember on top of my head -- have you noticed anything out of the ordinary?
Author
There was a problem hiding this comment.
Ah, i did not look very deeply: i just ran the tests and checked that nothing refers directly to observeAndSample.
Author
|
I pushed a fixed for the build issue with |
Author
|
A few more cleanups, and the build is green! ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds GHC 9.10.2 to
tested-withand the CI matrix, and updates theprometheusdependency to allow 2.3.0.Are there other GHC versions we also want to add, while here?