Skip to content

[new] Make groups collapsable#56

Open
pramodjodhani wants to merge 6 commits intoiconicwp:masterfrom
pramodjodhani:feature/collapse-repeater
Open

[new] Make groups collapsable#56
pramodjodhani wants to merge 6 commits intoiconicwp:masterfrom
pramodjodhani:feature/collapse-repeater

Conversation

@pramodjodhani
Copy link
Copy Markdown
Collaborator

@pramodjodhani pramodjodhani commented Jul 29, 2021 •
edited
Loading

wsf-collapsable.mp4

@pramodjodhani pramodjodhani requested a review from jamesckemp July 29, 2021 12:21
@pramodjodhani pramodjodhani mentioned this pull request Jul 29, 2021
Merged
jamesckemp
jamesckemp reviewed Aug 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jamesckemp jamesckemp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pramodjodhani Please attach a video so I can see it in action

@pramodjodhani
Copy link
Copy Markdown
Collaborator Author

pramodjodhani commented Aug 10, 2021 •
edited
Loading

@jamesckemp
Done, but I encountered two bugs:

  • Header is not deleted when the row is deleted
  • When new row is created it shows the wrong arrow (shows down array instead of right arrow)

I will fix them soon.

@pramodjodhani
1. Use correct arrow (down) when a new row is created
b06b57b 
2. Delete header when row is deleted
@pramodjodhani
Copy link
Copy Markdown
Collaborator Author

pramodjodhani commented Aug 11, 2021

@jamesckemp I have fixed the issues. It's back to you.

@mattwatsoncodes mattwatsoncodes requested review from mattwatsoncodes and removed request for jamesckemp September 22, 2021 09:55
@mattwatsoncodes mattwatsoncodes self-assigned this Sep 22, 2021
@pramodjodhani pramodjodhani mentioned this pull request Sep 24, 2021
Merged
mattwatsoncodes
mattwatsoncodes approved these changes Sep 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mattwatsoncodes mattwatsoncodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great 👍

@pramodjodhani
Copy link
Copy Markdown
Collaborator Author

pramodjodhani commented Oct 8, 2021 •
edited
Loading

@jamesckemp would you give it a final nod and maybe merge if all is good?

@pramodjodhani
Copy link
Copy Markdown
Collaborator Author

pramodjodhani commented Nov 8, 2021 •
edited
Loading

Noticed more issues:

  • The add icon is hidden when the group is collapsed
  • When a new group item is added, it requires 2 clicks to collapse it.

@pramodjodhani pramodjodhani self-assigned this Nov 8, 2021
@pramodjodhani pramodjodhani removed their assignment Nov 10, 2021
@pramodjodhani pramodjodhani changed the title Make groups collapsable [new] Make groups collapsable Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamesckemp jamesckemp Awaiting requested review from jamesckemp

1 more reviewer

@mattwatsoncodes mattwatsoncodes mattwatsoncodes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jamesckemp jamesckemp

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pramodjodhani @jamesckemp @mattwatsoncodes @dave-green-uk