Mark mutable strings to fix ruby 3.4 warnings #59
Conversation
iconara
left a comment
iconara
left a comment
There was a problem hiding this comment.
Thank you for the fix. I have not made any releases for this gem in years and can't promise that I can do one quickly or even at all, but I will put it on my todo list to make an attempt. Please remove the version bump from the PR, anchor I can merge these changes at least.
lib/ione/version.rb
Outdated
|
|
||
| module Ione | ||
| VERSION = '1.3.0.pre3'.freeze | ||
| VERSION = '1.3.1'.freeze |
There was a problem hiding this comment.
Please remove this change. The version will be set in a separate commit before a release.
There was a problem hiding this comment.
Thanks for checking it @iconara, I've removed the version change.
|
I merged this, but I can't get the tests to run in a modern Ruby. They were written for RSpec 2.x and I guess that isn't working anymore. A lot of the tests seem to require rewriting to get things running, and I don't know how to find the time to do that. I've not written Ruby in years unfortunately. |
2 participants
Marking mutable strings to fix ruby 3.4 warnings.