Remove Slice1 and compilation mode from Compiler definitions#27
Merged
bernardnormier merged 3 commits intoicerpc:mainfrom Feb 11, 2026
Merged
Remove Slice1 and compilation mode from Compiler definitions#27bernardnormier merged 3 commits intoicerpc:mainfrom
bernardnormier merged 3 commits intoicerpc:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request removes Slice1-specific language constructs from the compiler's internal representation. The changes simplify the compiler's data model by eliminating support for deprecated Slice1 features (classes, exceptions, and compilation modes) while maintaining support for Slice1 files in the actual codebase (Ice/ and IceRpc/ directories use mode = Slice1).
Changes:
- Removed Class and Exception struct definitions from the compiler's internal AST representation
- Removed CompilationMode enum and associated metadata tracking
- Removed exception-related documentation metadata (ThrowsTag and throws field)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Compiler/SyntaxElements.slice | Removed Class and Exception structs, isSlice1Only field from Struct, and exceptionSpecification from Operation; reordered fields in Interface, Operation, and Enum |
| Compiler/DocComment.slice | Removed ThrowsTag struct and throws field from DocComment to eliminate exception documentation metadata |
| Compiler/CodeGenerator.slice | Removed CompilationMode enum, compilationMode field from SliceFile, and Class/Exception variants from Definition enum |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bernardnormier
commented
Feb 5, 2026
|
|
||
| struct Operation { | ||
| entityInfo: EntityInfo | ||
| isIdempotent: bool |
Member
Author
There was a problem hiding this comment.
I think it's more logical to put idempotent toward to front, like in the Slice syntax.
pepone
approved these changes
Feb 6, 2026
externl
approved these changes
Feb 6, 2026
InsertCreativityHere
approved these changes
Feb 6, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.