Update Interop examples to Ice 3.8#4264
Open
bernardnormier wants to merge 4 commits intoicerpc:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Slice-based Ice interop examples and related documentation links to align with ZeroC Ice 3.8 (switching the examples to the Ice 3.8 “greeter” demos and refreshing doc URLs).
Changes:
- Replace the old “minimal” interop example with a new
InteropGreeterexample targeting Ice 3.8 greeter. - Update
InteropIceGridto use a Greeter Slice contract and the IceGrid greeter demo conventions. - Refresh various Ice documentation links (including moving an older 3.7 link to the archive domain).
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/IceRpc/ConnectionOptions.cs | Updates a documentation link for Ice ACM heartbeat configuration. |
| src/IceRpc.RequestContext/README.md | Updates Ice request context documentation link to Ice 3.8. |
| src/IceRpc.Locator/README.md | Updates Ice locator documentation link to Ice 3.8. |
| examples/slice/README.md | Updates the examples index: adds InteropGreeter and removes InteropMinimal. |
| examples/slice/InteropMinimal/slice/Hello.slice | Removes the deprecated InteropMinimal Slice contract. |
| examples/slice/InteropMinimal/Server/HelloService.cs | Removes the deprecated InteropMinimal server implementation. |
| examples/slice/InteropMinimal/README.md | Removes the deprecated InteropMinimal documentation. |
| examples/slice/InteropMinimal/Client/Program.cs | Removes the deprecated InteropMinimal client program. |
| examples/slice/InteropIceGrid/slice/Hello.slice | Removes the old Hello Slice contract for the IceGrid interop example. |
| examples/slice/InteropIceGrid/slice/Greeter.slice | Adds the Greeter Slice contract for Ice 3.8 IceGrid greeter demo interop. |
| examples/slice/InteropIceGrid/README.md | Updates instructions/links to point to Ice 3.8 IceGrid greeter demos. |
| examples/slice/InteropIceGrid/Client/Program.cs | Updates the client to use Greeter and the IceGrid locator identity conventions. |
| examples/slice/InteropIceGrid/Client/Client.csproj | Switches Slice input from Hello.slice to Greeter.slice. |
| examples/slice/InteropGreeter/slice/Greeter.slice | Adds a new Greeter Slice contract for the new interop example. |
| examples/slice/InteropGreeter/Server/Server.csproj | Adds new InteropGreeter server project wiring for Greeter.slice. |
| examples/slice/InteropGreeter/Server/Program.cs | Adds an Ice protocol server entrypoint using default ice port. |
| examples/slice/InteropGreeter/Server/Chatbot.cs | Adds Greeter service implementation with Ice checked-cast support. |
| examples/slice/InteropGreeter/README.md | Adds documentation for the new Ice 3.8 greeter interop example. |
| examples/slice/InteropGreeter/InteropGreeter.slnx | Adds a solution file for the new example. |
| examples/slice/InteropGreeter/Client/Program.cs | Adds an Ice protocol client calling /greeter. |
| examples/slice/InteropGreeter/Client/Client.csproj | Adds new InteropGreeter client project wiring for Greeter.slice. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | [Download](./Download/) | Shows how to download a file from a server by streaming this file. | | ||
| | [GenericHost](./GenericHost/) | Shows how to create client and server applications using Microsoft's Dependency Injection container. | | ||
| | [Greeter](./Greeter/) | Shows how to call and implement a canonical Greeter service using the IceRPC + Slice integration. | | ||
| | [InteropGreeter](./InteropGreeter/) | shows how an IceRPC client can call a service hosted by an [Ice] server, and vice-versa. | |
There was a problem hiding this comment.
In the examples table, this description starts with a lowercase “shows”, while the rest of the table consistently uses “Shows …”. Consider capitalizing it (and optionally using “vice versa” without the hyphen) to keep the documentation consistent.
Suggested change
| | [InteropGreeter](./InteropGreeter/) | shows how an IceRPC client can call a service hosted by an [Ice] server, and vice-versa. | | |
| | [InteropGreeter](./InteropGreeter/) | Shows how an IceRPC client can call a service hosted by an [Ice] server, and vice versa. | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades the two Interop examples to use Ice 3.8. It also replaces a few references to Ice 3.7 by references to Ice 3.8.