Skip to content

Remove RestoreLockedMode and lock files#4263

Merged
bernardnormier merged 1 commit intoicerpc:mainfrom
bernardnormier:x-lock-on-restore
Feb 28, 2026
Merged

Remove RestoreLockedMode and lock files#4263
bernardnormier merged 1 commit intoicerpc:mainfrom
bernardnormier:x-lock-on-restore

Conversation

@bernardnormier
Copy link
Member

This PR removes RestoreLockedMode and the associated lock files on main.

We should enable this feature when we release - but not on the main development branch.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables NuGet “locked restore” on the main development branch by removing the MSBuild properties that enforced lock files, and deletes the existing packages.lock.json files from src and tests.

Changes:

  • Remove RestorePackagesWithLockFile and RestoreLockedMode from src/Directory.Build.props and tests/Directory.Build.props.
  • Delete all committed packages.lock.json files under src/** and tests/**.

Reviewed changes

Copilot reviewed 45 out of 45 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/ZeroC.Slice.Tests/packages.lock.json Remove NuGet lock file from test project
tests/ZeroC.Slice.Tests.ReferencedAssemblies/DPrime/packages.lock.json Remove NuGet lock file from referenced-assemblies test project
tests/ZeroC.Slice.Tests.ReferencedAssemblies/D/packages.lock.json Remove NuGet lock file from referenced-assemblies test project
tests/ZeroC.Slice.Tests.ReferencedAssemblies/C/packages.lock.json Remove NuGet lock file from referenced-assemblies test project
tests/ZeroC.Slice.Tests.ReferencedAssemblies/B/packages.lock.json Remove NuGet lock file from referenced-assemblies test project
tests/ZeroC.Slice.Tests.ReferencedAssemblies/A/packages.lock.json Remove NuGet lock file from referenced-assemblies test project
tests/IntegrationTests/packages.lock.json Remove NuGet lock file from integration tests
tests/IceRpc.Tests/packages.lock.json Remove NuGet lock file from test project
tests/IceRpc.Tests.Common/packages.lock.json Remove NuGet lock file from shared test utilities project
tests/IceRpc.Telemetry.Tests/packages.lock.json Remove NuGet lock file from telemetry tests
tests/IceRpc.Slice.Tests/packages.lock.json Remove NuGet lock file from Slice tests
tests/IceRpc.Retry.Tests/packages.lock.json Remove NuGet lock file from retry tests
tests/IceRpc.RequestContext.Tests/packages.lock.json Remove NuGet lock file from request-context tests
tests/IceRpc.Quic.Tests/packages.lock.json Remove NuGet lock file from QUIC tests
tests/IceRpc.Protobuf.Tests/packages.lock.json Remove NuGet lock file from protobuf tests
tests/IceRpc.Metrics.Tests/packages.lock.json Remove NuGet lock file from metrics tests
tests/IceRpc.Logger.Tests/packages.lock.json Remove NuGet lock file from logger tests
tests/IceRpc.Locator.Tests/packages.lock.json Remove NuGet lock file from locator tests
tests/IceRpc.Extensions.DependencyInjection.Tests/packages.lock.json Remove NuGet lock file from DI extension tests
tests/IceRpc.Conformance.Tests/packages.lock.json Remove NuGet lock file from conformance tests
tests/IceRpc.Compressor.Tests/packages.lock.json Remove NuGet lock file from compressor tests
tests/Directory.Build.props Stop enforcing lock files / locked restore for test builds
src/ZeroC.Slice/packages.lock.json Remove NuGet lock file from library project
src/IceRpc/packages.lock.json Remove NuGet lock file from library project
src/IceRpc.Transports.Coloc/packages.lock.json Remove NuGet lock file from library project
src/IceRpc.Telemetry/packages.lock.json Remove NuGet lock file from library project
src/IceRpc.SliceBuildTelemetry.Reporter/packages.lock.json Remove NuGet lock file from tool project
src/IceRpc.Slice/packages.lock.json Remove NuGet lock file from library project
src/IceRpc.Slice.Tools/packages.lock.json Remove NuGet lock file from tool project
src/IceRpc.Slice.Generators/packages.lock.json Remove NuGet lock file from generator project
src/IceRpc.Retry/packages.lock.json Remove NuGet lock file from library project
src/IceRpc.RequestContext/packages.lock.json Remove NuGet lock file from library project
src/IceRpc.ProtocGen/packages.lock.json Remove NuGet lock file from tool project
src/IceRpc.ProtocGen.BuildTelemetry/packages.lock.json Remove NuGet lock file from tool project
src/IceRpc.Protobuf/packages.lock.json Remove NuGet lock file from library project
src/IceRpc.Protobuf.Tools/packages.lock.json Remove NuGet lock file from tool project
src/IceRpc.Protobuf.Generators/packages.lock.json Remove NuGet lock file from generator project
src/IceRpc.Metrics/packages.lock.json Remove NuGet lock file from library project
src/IceRpc.Logger/packages.lock.json Remove NuGet lock file from library project
src/IceRpc.Locator/packages.lock.json Remove NuGet lock file from library project
src/IceRpc.Extensions.DependencyInjection/packages.lock.json Remove NuGet lock file from library project
src/IceRpc.Deadline/packages.lock.json Remove NuGet lock file from library project
src/IceRpc.Compressor/packages.lock.json Remove NuGet lock file from library project
src/Directory.Build.props Stop enforcing lock files / locked restore for src builds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bernardnormier bernardnormier merged commit ad06cd1 into icerpc:main Feb 28, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants