Modded block demo: Thermal Expansion's rockwool

[iceiix]

Add minimal support for a simple modded block

The chosen block to support: https://ftb.gamepedia.com/Rockwool_(Thermal_Expansion_3)

• Forge handshake support and parsing (1.7.10: Forge handshake support #88 Add Forge handshake support (#88) #134 Forge 1.8.9-1.12.2 handshake protocol support #144)
• Enhance steven_blocks macro to label block modid
• Define a simple easily implementable modded block (ThermalExpansion:Rockwool)
• Add modid lookup if id not in vanilla, split metadata
• Link ModIdData/RegistryData to supported modded block modid lookup, removing hardcoded id
• Test on 1.7.10 + forge 10.13.4.1614 + ThermalExpansion-[1.7.10]4.1.5-248
• Test on 1.10.2 + FTB Beyond 1.11.0
• Test on 1.12.2 + forge 1.12.2-14.23.5.2815 + CoFHCore-1.12.2-4.6.2.25 + CoFHWorld-1.12.2-1.3.0.6 + CodeChickenLib-1.12.2-3.2.2.353 + RedstoneFlux-1.12-2.1.0.6 + ThermalExpansion-1.12.2-5.5.3.41 + ThermalFoundation-1.12.2-2.6.2.26

[iceiix]

This basically works, but the leading \u{2} byte on the block name seems wrong. Some other ids have \u{1}. Doesn't appear to be documented on https://wiki.vg/Minecraft_Forge_Handshake#ModIdData. What does this leading byte mean? Block vs item?

Not obvious from https://github.com/MinecraftForge/MinecraftForge/blob/1.7.10/fml/src/main/java/cpw/mods/fml/common/network/handshake/FMLHandshakeMessage.java#L153

        public void fromBytes(ByteBuf buffer)
        {
            int length = ByteBufUtils.readVarInt(buffer, 3);
            modIds = Maps.newHashMap();
            blockSubstitutions = Sets.newHashSet();
            itemSubstitutions = Sets.newHashSet();

            for (int i = 0; i < length; i++)
            {
                modIds.put(ByteBufUtils.readUTF8String(buffer),ByteBufUtils.readVarInt(buffer, 3));
            }

[iceiix]

There is a discriminator byte in https://github.com/MinecraftForge/MinecraftForge/blob/1.7.10/fml/src/main/java/cpw/mods/fml/common/registry/FMLControlledNamespacedRegistry.java#L340

            idMapping.put(discriminator+getNameForObject(thing), getId(thing));

The two discriminators are defined in https://github.com/MinecraftForge/MinecraftForge/blob/1.7.10/fml/src/main/java/cpw/mods/fml/common/registry/GameData.java#L763-L766

        iBlockRegistry = new FMLControlledNamespacedRegistry<Block>("minecraft:air", MAX_BLOCK_ID, MIN_BLOCK_ID, Block.class,'\u0001');
        iItemRegistry = new FMLControlledNamespacedRegistry<Item>(null, MAX_ITEM_ID, MIN_ITEM_ID, Item.class,'\u0002');

So, \u{1} = block, \u{2} = item.

[iceiix]

The 1.12.2 modpack tested in #148 doesn't have Thermal Expansion. Setting up a clean 1.12.2 server with the following (http://teamcofh.com/downloads/):

• forge-1.12.2-14.23.5.2815-universal.jar
• CoFHCore-1.12.2-4.6.2.25-universal.jar
• CoFHWorld-1.12.2-1.3.0.6-universal.jar
• CodeChickenLib-1.12.2-3.2.2.353-universal.jar
• RedstoneFlux-1.12-2.1.0.6-universal.jar
• ThermalExpansion-1.12.2-5.5.3.41-universal.jar
• ThermalFoundation-1.12.2-2.6.2.26-universal.jar

Block name changed. Login and run command setblock -200 66 255 thermalfoundation:rockwool 1 on the server console.

[iceiix]

1.7.10:

1.10.2:

1.12.2: