Skip to content

Rewrite _preferredIconSize method for icon sizing#295

Open
joevnpro wants to merge 2 commits intoicedman:mainfrom
joevnpro:joevnpro-patch-1
Open

Rewrite _preferredIconSize method for icon sizing#295
joevnpro wants to merge 2 commits intoicedman:mainfrom
joevnpro:joevnpro-patch-1

Conversation

@joevnpro
Copy link

Refactor _preferredIconSize method to prioritize manual input and UI slider for icon size calculation.

Refactor _preferredIconSize method for clarity and wider limitation (smaller to bigger)

Refactor _preferredIconSize method to prioritize manual input and UI slider for icon size calculation.


Refactor _preferredIconSize method for clarity and wider limitation (smaller to bigger)
@icedman
Copy link
Owner

icedman commented Mar 2, 2026

Thanks for this. This solves icon scaling issues. Could you think of a why to adjust the settings of users. So as not to surprise them with the sudden icon size change.

@joevnpro
Copy link
Author

joevnpro commented Mar 7, 2026

I noticed a faulty initialization and a lack of a strong two-way link between the icon resizing slider on the UI control. This needs fixing.

Then, setting the initial/default position for the slider should work (the current initial position should always be the smallest). Or, use the slider position value that the user has already set.

Alternatively: provide a "what's new" notification to let them know and allow them to make changes.

Alternatively: make changes gradually. Increase or decrease the min/max values ​​gradually over several updates, each time by no more than 15%, to allow users to adapt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants